Update dependencies #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids depending on a "milestone" version.
This requires us to add an explicit dependency on the JAXB implementation. Also replace the dependency on ph-commons with a dependency on ph-jaxb, as we only use a method defined in the IJAXBReader interface, which is part of ph-jaxb, and nothing from ph-commons.
We don't need to depend on those packages.
ph-genericode 7.x uses JAXB 4.0, so we need to update our explicit dependency. JAXB 4.0 brings the namespace change from javax.xml.bind to jakarta.xml.bind. This does not impact us directly, as we don't have any reference to it, but it might impact users who rely on the indirect dependency on a JAXB implementation.
Fixes issue #29.
rouschr
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the versions of various dependencies (ph-genericode, JAXB, Antlr4), and cleanup some unused dependencies. See individual commits for details.
I will create a similar PR for efx-toolkit-java, as we should avoid mixing up various versions of the same dependency, as this can create problems.